Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] fix(Tag): improve a11y label #5437

Merged
merged 1 commit into from
Jul 12, 2022

Conversation

bvandercar-vt
Copy link
Contributor

Fixes #0000

Checklist

  • [N/A] Includes tests
  • [N/A] Update documentation

Changes proposed in this pull request:

Currently, a tag that has tabIndex > -1, when tabbed to in a screen reader, is also reading the remove button when reading the whole tag-- this should be excluded from reading the value of the tag-- the tag's remove button would be the next item being tabbed to.

… a screen reader when the whole tag is tabbed to
@adidahiya adidahiya changed the title label tag by its text to exclude the removeButton from being read by screenreader when the whole tag is tabbed to [core] fix(Tag): improve a11y label Jul 12, 2022
@adidahiya adidahiya merged commit 81147fc into palantir:develop Jul 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants