Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] fix(Slider, MultiSlider): improve a11y markup #5438

Merged
merged 9 commits into from
Jul 20, 2022
Merged

[core] fix(Slider, MultiSlider): improve a11y markup #5438

merged 9 commits into from
Jul 20, 2022

Conversation

bvandercar-vt
Copy link
Contributor

Fixes #0000

Checklist

  • Includes tests
  • Update documentation

Changes proposed in this pull request:

improve slider a11y per this official ARIA example: https://www.w3.org/WAI/ARIA/apg/example-index/slider/slider-multithumb.html

@adidahiya adidahiya changed the title improve slider a11y [core] fix(Slider, MultiSlider): improve a11y markup Jul 19, 2022
adidahiya
adidahiya suggested changes Jul 20, 2022
View reviewed changes
Copy link
Contributor

@adidahiya adidahiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just one small edit. <Handle handleHtmlProps={...}> feels verbose/redundant so I prefer <Handle htmlProps={...}>.

<Slider handleHtmlProps={...}> is sufficiently verbose, though, let's keep that prop name.

packages/core/src/components/slider/handleProps.tsx Outdated Show resolved Hide resolved
@adidahiya adidahiya merged commit cc00e06 into palantir:develop Jul 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adidahiya adidahiya adidahiya approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bvandercar-vt @adidahiya