-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[core] fix(Slider, MultiSlider): improve a11y markup #5438
Merged
adidahiya
merged 9 commits into
palantir:develop
from
bvandercar-vt:bv/RangeSlider-a11y
Jul 20, 2022
Merged
[core] fix(Slider, MultiSlider): improve a11y markup #5438
adidahiya
merged 9 commits into
palantir:develop
from
bvandercar-vt:bv/RangeSlider-a11y
Jul 20, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bvandercar-vt
commented
Jul 12, 2022
adidahiya
suggested changes
Jul 19, 2022
packages/docs-app/src/examples/core-examples/collapsibleListExample.tsx
Outdated
Show resolved
Hide resolved
adidahiya
changed the title
improve slider a11y
[core] fix(Slider, MultiSlider): improve a11y markup
Jul 19, 2022
Co-authored-by: Adi Dahiya <adi.dahiya14@gmail.com>
bvandercar-vt
commented
Jul 19, 2022
adidahiya
suggested changes
Jul 20, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Just one small edit. <Handle handleHtmlProps={...}>
feels verbose/redundant so I prefer <Handle htmlProps={...}>
.
<Slider handleHtmlProps={...}>
is sufficiently verbose, though, let's keep that prop name.
adidahiya
suggested changes
Jul 20, 2022
adidahiya
approved these changes
Jul 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #0000
Checklist
Changes proposed in this pull request:
improve slider a11y per this official ARIA example: https://www.w3.org/WAI/ARIA/apg/example-index/slider/slider-multithumb.html