[datetime2] feat(DateInput2): use Popover2, port DateInput impl #5440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Port DateInput popover/input impl into DateInput2Previews: documentation | landing | table | demo |
fix DateInput2 testsPreviews: documentation | landing | table | demo |
port DateInput tests, part 1Previews: documentation | landing | table | demo |
port DateInput tests, part 2Previews: documentation | landing | table | demo |
attempt to port one more testPreviews: documentation | landing | table | demo |
port DateInput tests, part 4Previews: documentation | landing | table | demo |
|
There's a bug in controlled mode -- the "Invalid date" message does not appear after typing in an invalid date:
|
improve error states in controlled modePreviews: documentation | landing | table | demo |
|
Things are much better now, but there is still this weird state you can get into when typing an incomplete date and the timezone is interpreted as a very unexpected offset:
Will fix that in a follow-up PR. |
show error styling if message is presentPreviews: documentation | landing | table | demo |
adidahiya
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Changes proposed in this pull request:
Despite what the docs stated before this change, we were not using Popover2 properly in DateInput2. It was delegating to DateInput for the text input + popover implementation, which used Popover.
This PR ports over the remaining code from DateInput into DateInput2 and migrates to Popover2.
Reviewers should focus on:
Screenshot