Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core,table] fix: make some props.children optional again #5446

Merged
merged 1 commit into from
Jul 20, 2022
Merged

[core,table] fix: make some props.children optional again #5446

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/core/src/components/collapse/collapse.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ export type CollapseProps = ICollapseProps;
/** @deprecated use CollapseProps */
export interface ICollapseProps extends Props {
/** Contents to collapse. */
children: React.ReactNode;
children?: React.ReactNode;

/**
* Component to render as the root element.
Expand Down
2 changes: 1 addition & 1 deletion packages/core/src/components/collapsible-list/collapsibleList.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ export type CollapsibleListProps = ICollapsibleListProps;
/** @deprecated use CollapsibleListProps */
export interface ICollapsibleListProps extends Props {
/** Contents to collapse. */
children: React.ReactNode;
children?: React.ReactNode;

/**
* Element to render as dropdown target with `CLICK` interaction to show collapsed menu.
Expand Down
2 changes: 1 addition & 1 deletion packages/core/src/components/dialog/multistepDialog.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ export interface IMultistepDialogProps extends DialogProps {
backButtonProps?: DialogStepButtonProps;

/** Dialog steps. */
children: React.ReactNode;
children?: React.ReactNode;

/**
* Props for the close button that appears in the footer when there is no
Expand Down
2 changes: 1 addition & 1 deletion packages/table/src/common/contextMenuTargetWrapper.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ import * as React from "react";
import { ContextMenuTarget, IProps } from "@blueprintjs/core";

export interface IContextMenuTargetWrapper extends IProps {
children: React.ReactNode;
children?: React.ReactNode;
renderContextMenu: (e: React.MouseEvent<HTMLElement>) => JSX.Element | undefined;
style: React.CSSProperties;
}
Expand Down
2 changes: 1 addition & 1 deletion packages/table/src/interactions/reorderable.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ export interface IReorderableProps {

export interface IDragReorderable extends IReorderableProps {
/** Element to drag & reorder. */
children: React.ReactNode;
children?: React.ReactNode;

/**
* Whether the reordering behavior is disabled.
Expand Down
2 changes: 1 addition & 1 deletion packages/table/src/interactions/selectable.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ export interface ISelectableProps {

export interface IDragSelectableProps extends ISelectableProps {
/** Element to make interactive. */
children: React.ReactNode;
children?: React.ReactNode;

/**
* A list of CSS selectors that should _not_ trigger selection when a `mousedown` occurs inside of them.
Expand Down