[table] feat: ColumnHeaderCell2, TruncatedFormat2, JSONFormat2 #5481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[table] feat(ColumnHeaderCell, TruncatedFormat): use Popover2Previews: documentation | landing | table | demo |
fix testsPreviews: documentation | landing | table | demo |
Merge remote-tracking branch 'origin/develop' into ad/table-v2-componentsPreviews: documentation | landing | table | demo |
|
Changed my mind -- I think we should split these out into new v2 components, as the breaking change is not worth it. If we make the change directly to ColumnHeaderCell and TruncatedFormat, then some consumers who have not migrated to Popover2 yet will get broken column header menus immediately after this upgrade, and that feel unnecessary. |
refactor into v2 componentsPreviews: documentation | landing | table | demo |
more migrations, docs updatesPreviews: documentation | landing | table | demo |
adidahiya
changed the title
commit missing filesPreviews: documentation | landing | table | demo |
update docs, fix formatting example to detect truncationPreviews: documentation | landing | table | demo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5480
Changes proposed in this pull request:
blueprint-popover2.cssin table-dev-app, add documentation for this new requirementThis PR also fixes an undocumented issue in the table "Formatting" example where the cell truncation was not being detected, and thus the overflow popover was never shown. It's now fixed with
detectTruncation={true}:Reviewers should focus on:
Minor breaking change in table, requiring users to importblueprint-popover2.css. We expect most consumers to be using @blueprintjs/popover2 already at this point, so this should not be too much of a burden (likely a no-op).We're avoiding the breaking change by splitting these out into new components. Consumers of the new components will need to add the CSS import when they migrate.
Screenshot
ColumnHeaderCell2
TruncatedFormat2