Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] fix: partially revert #5493, create Portal2 #5512

Merged
merged 2 commits into from
Aug 24, 2022

Conversation

adidahiya
Copy link
Contributor

@adidahiya adidahiya commented Aug 24, 2022

Changes proposed in this pull request:

#5493 caused some unintentional subtle breaks in interactions between the newly refactored Portal function component and the (long-deprecated) react-hot-loader library. To be extra safe, we're going to punt this component refactor to Blueprint v5.0.

This PR reverts Portal to be a class component. I haven't fully reverted #5493 because I wanted to keep the changes which removed React 15 support (which we stopped supporting a long time ago).

The new Portal function component implementation from #5493 is being kept in the repo as Portal2. For now, it is unused. #5511 tracks promoting Portal2 -> Portal in Blueprint v5.0 (along with the new tests and PortalProvider functionality).

@blueprint-bot
Copy link

[core] fix: partially revert #5493, create Portal2

Previews: documentation | landing | table | demo

@blueprint-bot
Copy link

minor docs fix

Previews: documentation | landing | table | demo

@adidahiya adidahiya merged commit 0bed48f into develop Aug 24, 2022
@adidahiya adidahiya deleted the ad/revert-portal-refactor branch August 24, 2022 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants