-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[core] feat(MultistepDialog): tooltips on navigation buttons #5534
Conversation
Thanks for your interest in palantir/blueprint, @ohcnivek! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request. |
packages/docs-app/src/examples/core-examples/multistepDialogExample.tsx
Outdated
Show resolved
Hide resolved
There's another issue here -- Tooltips don't play nicely with disabled Buttons. This edge case will be common with the I'll push a commit here to make these fixes. |
docs preview build looks good 👍🏽 |
Fixes #5519
Checklist
Changes proposed in this pull request:
tooltipContent
, toabstractButton.tsx
props, which by association enables the prop to exist onDialogStepButtonProps
tooltipContent
prop exists (user should define when it exists / doesnt, checkout the example.packages/docs-app/src/examples/core-examples/multistepDialogExample.tsx
)Reviewers should focus on:
Screenshot
Screen.Recording.2022-09-10.at.1.47.00.AM.mov