-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[stylelint-plugin] feat: migrate from @import to @use statements #5640
Conversation
Update docsPreviews: documentation | landing | table | demo |
Apply PR suggestionsPreviews: documentation | landing | table | demo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM other than the one comment here. We'll release this as a breaking change to the rule in a new major version for the plugin.
hasBpVariablesImport = checkImportExists( | ||
cssSyntaxType, | ||
root, | ||
[importPath, `${importPath}.${extension}`], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor: can we now infer the file extension from the first argument cssSyntaxType
? it seems like we no longer need an array of import paths, we can just provide one and checkImportExists
should check for both paths with and without the extension.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll address this in a follow-up PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@blueprintjs/stylelint-plugin
now supports Sass@use
and drops support for Sass@import
. Less@import
support remains.