Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

break: migrate webpack + karma build scripts to ES modules #5644

Merged
merged 4 commits into from
Oct 5, 2022

Conversation

adidahiya
Copy link
Contributor

@adidahiya adidahiya commented Oct 5, 2022

Changes proposed in this pull request:

  • [webpack-build-scripts] break: migrate config scripts to ES modules
    • ⚠️ this package's API has not changed in shape, but it can no longer be imported using require() - you must use await import() or an ES import instead
  • [webpack-build-scripts] break: change default dev server port to 9001
  • [webpack-build-scripts] fix(dev-server): add host: "0.0.0.0" option by default to obviate need for --host 0.0.0.0 CLI argument
  • [webpack-build-scripts] fix(dev-server): add react-refresh-typescript for HMR
  • [karma-build-scripts] break: migrate config scripts to ES modules
    • ⚠️ this package's API has not changed in shape, but it can no longer be imported using require() - you must use await import() or an ES import instead
  • [eslint-config] fix: while linting .js or .mjs files, assume ES 2022 syntax in parser and allow ES default exports by disabling import/no-default-export rule

See docs for webpack-dev-server migration to v4.

@blueprint-bot
Copy link

[webpack-build-scripts] break: migrate scripts to ES modules

Previews: documentation | landing | table | demo

@adidahiya adidahiya changed the title [webpack-build-scripts] break: migrate scripts to ES modules break: migrate webpack + karma build scripts to ES modules Oct 5, 2022
@blueprint-bot
Copy link

add type to package.json

Previews: documentation | landing | table | demo

@adidahiya adidahiya merged commit cc59def into develop Oct 5, 2022
@adidahiya adidahiya deleted the ad/webpack-config branch October 5, 2022 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants