Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[icons] feat: new icon "regex" #5649

Merged
merged 4 commits into from
Oct 6, 2022
Merged

[icons] feat: new icon "regex" #5649

merged 4 commits into from
Oct 6, 2022

Conversation

chanelluu
Copy link
Contributor

@chanelluu chanelluu commented Oct 6, 2022

Changes proposed in this pull request:

Add Regex icon

Reviewers should focus on:

Make sure everything renders okay and the correct file was edited.

Screenshot

Screen Shot 2022-10-06 at 10 42 24 AM

Screen Shot 2022-10-06 at 10 42 58 AM

packages/icons/icons.json Outdated Show resolved Hide resolved
packages/icons/icons.json Outdated Show resolved Hide resolved
packages/icons/icons.json Outdated Show resolved Hide resolved
Co-authored-by: Adi Dahiya <adahiya@palantir.com>
@blueprint-bot
Copy link

Apply suggestions from code review

Previews: documentation | landing | table | demo

Copy link
Contributor

@adidahiya adidahiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

next time try running yarn format from the root of the repo to make sure you have all the code formatted properly

packages/icons/icons.json Outdated Show resolved Hide resolved
packages/icons/icons.json Outdated Show resolved Hide resolved
Copy link
Contributor

@adidahiya adidahiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

new icon shows up correctly in docs:

image

@adidahiya adidahiya changed the title feat: new icon - regex [icons] feat: new icon "regex" Oct 6, 2022
@blueprint-bot
Copy link

Update packages/icons/icons.json

Previews: documentation | landing | table | demo

@adidahiya adidahiya merged commit c3d3195 into develop Oct 6, 2022
@adidahiya adidahiya deleted the clh/regexIcon branch October 6, 2022 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants