Fix @types/react peer dependency version #5665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix @types/react peer dependency versionPreviews: documentation | landing | table | demo |
adidahiya
approved these changes
Oct 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm upgrading Blueprint in a project that uses
@types/react@16.14.11, but I get this error:It turns out the Blueprint repo itself uses 16.14.32, where the type has been updated to take 2 generic type parameters. I updated the peer dependency data to reflect that you need this new minimum. It could be that it was introduced earlier, but I figured its safer for the peer dependency to reflect what Blueprint itself is developing on to avoid future mismatches.