fix: migrate from lodash-es to lodash for CJS support #5666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: migrate from lodash-es to lodash for CJS supportPreviews: documentation | landing | table | demo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5536
Changes proposed in this pull request:
Switch from
lodash-estolodash(using submodule imports) to restore CommonJS support in @blueprintjs/datetime2 package.We could technically keep using
lodash-esin our application packages (demo-app, docs-app, table-dev-app), but it's simpler this way to only allow imports fromlodashacross the monorepo.We can switch back to
lodash-esin Blueprint v6 when we make a breaking change to drop CommonJS support (stop publishing a/lib/cjs/folder) and only support ESM.