Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrade classnames dependency to 2.3.1 #5687

Merged
merged 1 commit into from
Oct 24, 2022
Merged

Conversation

styu
Copy link
Contributor

@styu styu commented Oct 21, 2022

In 2.3.2, classnames changed their types to require esModuleInterop and/or changing to import * as classNames from "classnames". This relaxes the dependency in blueprint so that consumers that are not ready to bump to 2.3.2 have the choice to stay on 2.3.1

@styu styu marked this pull request as ready for review October 21, 2022 17:32
@blueprint-bot
Copy link

Downgrade classnames dependency to 2.3.1

Previews: documentation | landing | table | demo

@adidahiya adidahiya merged commit 26f8d3a into develop Oct 24, 2022
@adidahiya adidahiya deleted the syu/downgrade-classnames branch October 24, 2022 14:18
version "2.3.2"
resolved "https://registry.yarnpkg.com/classnames/-/classnames-2.3.2.tgz#351d813bf0137fcc6a76a16b88208d2560a0d924"
resolved "https://artifactory.palantir.build/artifactory/api/npm/all-npm/classnames/-/classnames-2.3.2.tgz#351d813bf0137fcc6a76a16b88208d2560a0d924"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

really strange that this did not fail the build with an artifactory URL 😮

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whooooops

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants