[eslint-plugin] fix(no-deprecated-type-references): handle name conflicts with import aliases for new types #5708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gluxon
approved these changes
Oct 31, 2022
Comment on lines
+52
to
+54
| } else if (options.alias !== undefined && nodeToReplace.local.name !== nodeToReplace.imported.name) { | ||
| throw new Error( | ||
| `Existing import '${nodeToReplace.imported.name}' is already aliased as '${nodeToReplace.local.name}', refusing to rename with new alias '${options.alias}'`, |
There was a problem hiding this comment.
Good catch of this situation!
[eslint-plugin] fix(no-deprecated-type-references): deal with name conflictsPreviews: documentation | landing | table | demo |
adidahiya
changed the title
adidahiya
deleted the
ad/fix-deprecated-type-references-name-conflicts
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Changes proposed in this pull request:
Improve
@blueprintjs/no-deprecated-type-referenceslint rule implementation to detect name conflicts for the new symbols. In these cases the rule will now alias the new type name with a "Blueprint" prefix, such as{ Props as BlueprintProps }.Reviewers should focus on:
New test cases