[select] popoverTargetProps and inputProps fixes & docs #5730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[select] fix: unify & clarify popoverTargetProps supportPreviews: documentation | landing | table | demo |
fix up various docs & typedefsPreviews: documentation | landing | table | demo |
adidahiya
commented
Nov 7, 2022
| case "keydown": | ||
| return event => { | ||
| handler?.(event); | ||
| this.props.popoverTargetProps?.onKeyDown?.(event); |
There was a problem hiding this comment.
this is a bugfix -- popoverTargetProps.onKey{Down|Up} handlers were never getting called before.
| @@ -252,6 +254,7 @@ export class Suggest2<T> extends AbstractPureComponent2<Suggest2Props<T>, Sugges | |||
| {...inputProps} | |||
| aria-autocomplete="list" | |||
| aria-expanded={isOpen} | |||
| className={classNames(targetProps.className, inputProps.className)} | |||
There was a problem hiding this comment.
this is also a bugfix -- inputProps.className was clobbering targetProps.className before, which would totally break things.
adidahiya
changed the title
adidahiya
changed the title
fix test compilationPreviews: documentation | landing | table | demo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
popoverTargetProps(prop available on Select2 and MultiSelect2) typedef & docs intoSelectPopoverPropspopoverTargetPropsis not supported on Suggest2, and users should useinputPropsinstead, as it does the same thing.MultiSelect2): invokepopoverTargetPropsonKeyDown/oKeyUpevent handlers if providedchore(Suggest2): clean up some code to make event handlers more legibleSuggest2): fix support forinputProps.className(it no longer overrides the popover class name, which caused all sorts of things to break)Reviewers should focus on:
No regressions (should be covered by test suites)