[datetime2] fix: non-nullable onChange adapter #5740
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
It's common to see code like this in a function component using DateInput:
When this gets migrated to DateInput2 using our automated codemods, it becomes:
... which nullifies the benefits of
useCallback
since a new function is being created every time. A better pattern would be:... but that did not type check before this PR because of the loose input/output types for the adapter which included
undefined
.This change fixes the type of
DateInput2MigrationUtils.onChangeAdapter
so the last code example works.