Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[icons] feat: "intel" icon #5856

Merged
merged 4 commits into from
Jan 23, 2023
Merged

Conversation

gredman2018
Copy link
Contributor

@gredman2018 gredman2018 commented Jan 19, 2023

Fixes #0000

Checklist

  • Includes tests
  • Update documentation

Changes proposed in this pull request:

Added a the new intelligence icon with 16px and 20px

Reviewers should focus on:

Everything renders correctly at both sizes!

Screenshot

Screenshot 2023-01-19 at 10 39 38 AM

@palantirtech
Copy link
Member

Thanks for your interest in palantir/blueprint, @gredman2018! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request.

Copy link
Contributor

@adidahiya adidahiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CPerinet to confirm design approval 👍🏽 / 👎🏽 ?

packages/icons/icons.json Outdated Show resolved Hide resolved
packages/icons/icons.json Outdated Show resolved Hide resolved
@adidahiya adidahiya changed the title Gr/intel icon [icons] feat: "intel" icon Jan 20, 2023
packages/icons/icons.json Outdated Show resolved Hide resolved
@adidahiya
Copy link
Contributor

sorry about the failing deploy-preview job -- I'll fix that -- here's the docs preview link: https://output.circle-artifacts.com/output/job/7ebf1edd-d362-4194-9fda-f8170c8baec9/artifacts/0/packages/docs-app/dist/index.html#icons

image

@gredman2018 gredman2018 requested review from CPerinet and removed request for CPerinet January 20, 2023 21:08
@gredman2018
Copy link
Contributor Author

Hi! When/how can I fix circleci deploy-preview failing?

@adidahiya
Copy link
Contributor

deploy-preview is returning a failing exit code because it's building on a fork and doesn't have the necessary environment variables. That's not a problem with your PR, just an issue with the preview script right now. It should exit gracefully with a successful exit code -- I'm going to fix that in a separate PR. In the meantime, I'll merge this PR, it's good to go :shipit:

@adidahiya adidahiya merged commit 2854765 into palantir:develop Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants