Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] fix dialog footer layout regression #5858

Merged
merged 1 commit into from
Jan 20, 2023

Conversation

adidahiya
Copy link
Contributor

@adidahiya adidahiya commented Jan 20, 2023

Similar to #5852, we also have to revert this padding -> margin change and only apply it for the new "fixed footer" class.

Before, with padding:

image

After, with margin:

image

Staying with margin allows existing code which uses <div className={Classes.DIALOG_FOOTER}> and applies margin style overrides to keep working, which is part of our CSS API contract.

@adidahiya
Copy link
Contributor Author

[core] fix dialog footer layout regression

Build artifact links for this commit: documentation | landing | table | demo

This is an automated comment from the deploy-preview CircleCI job.

@adidahiya adidahiya merged commit da8ffef into develop Jan 20, 2023
@adidahiya adidahiya deleted the ad/fix-dialog-footer-margin branch January 20, 2023 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant