[docs] migrate from highlights to new monaco-editor-theme package #5892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix distBuild artifact links for this commit: documentation | landing | table | demoThis is an automated comment from the deploy-preview CircleCI job. |
adidahiya
changed the title
bump CI cache keyBuild artifact links for this commit: documentation | landing | table | demoThis is an automated comment from the deploy-preview CircleCI job. |
adidahiya
commented
Jan 26, 2023
| @@ -96,7 +96,8 @@ $dark-options-background-color: $dark-gray4; | |||
| .docs-example-markup { | |||
| margin-top: $example-frame-spacing; | |||
|
|
|||
| .editor { | |||
| .editor, | |||
| .#{$ns}-code-block { | |||
There was a problem hiding this comment.
this should probably be .#{$ns}-docs-code-block
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially addresses #5895
Changes proposed in this pull request:
Remove
tree-sitter-typescriptandhighlightsfrom our build tooling -- these packages are outdated and will not work with newer versions of Node.js.I attempted to migrate to highlight.js, but found its TypeScript & JSX syntax support quite lacking.
Instead, I've added some basic support for a monaco editor theme with a new package called
@blueprintjs/monaco-editor-theme. This is not yet a full-fledged theme, but it's a good start. Syntax highlighting is now done on the client rather than during the docs build.Reviewers should focus on:
Visual appearance of the new code syntax colors, which should mostly achieve parity with the existing colors.
Screenshot