[popover2] fix(Popover2): get correct click target in shadow DOM #5909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adidahiya
suggested changes
Jan 31, 2023
packages/popover2/src/popover2.tsx
Outdated
| @@ -685,7 +685,7 @@ export class Popover2<T extends DefaultPopover2TargetHTMLProps> extends Abstract | |||
| return; | |||
| } | |||
|
|
|||
| const eventTarget = e.target as HTMLElement; | |||
| const eventTarget = (e.composed ? e.composedPath()[0] : e.target) as HTMLElement; | |||
There was a problem hiding this comment.
this approach seems reasonable, but I think you'll need to access e.nativeEvent.composedPath (docs)
There was a problem hiding this comment.
It makes sense according to e is "React.SyntheticEvent". But actually the caller of this function passes native event instead of React.SyntheticEvent.
I guess in that case I can check that "e" has "nativeEvent" and use it, otherwise use "e"
There was a problem hiding this comment.
So I updated the code
adidahiya
changed the title
adidahiya
approved these changes
Feb 1, 2023
|
thanks @kutensky |
Thank you for such a quick response. That fix will help to close a bug in our application |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5908
Checklist
Changes proposed in this pull request:
Get the actual click target. The same way it was done in "overlay.tsx" in function "handleDocumentClick"