Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actually update aria-hidden in Collapse #5926

Merged
merged 1 commit into from
Feb 7, 2023
Merged

Actually update aria-hidden in Collapse #5926

merged 1 commit into from
Feb 7, 2023

Conversation

styu
Copy link
Contributor

@styu styu commented Feb 6, 2023

This is reproducible in the blueprint docs - if you open/close the collapse, aria-hidden doesn't actually change:

image

I think it's because aria-hidden should reflect whether we're actually hiding children or not?

@adidahiya
Copy link
Contributor

Actually update aria-hidden in Collapse

Build artifact links for this commit: documentation | landing | table | demo

This is an automated comment from the deploy-preview CircleCI job.

@adidahiya adidahiya merged commit 45d307f into develop Feb 7, 2023
@adidahiya adidahiya deleted the styu-patch-1 branch February 7, 2023 14:09
shim-flounce added a commit to shim-flounce/blueprint that referenced this pull request Feb 15, 2023
This fixes regression introduced in palantir#5926 where if `keepChildrenMounted` is set, `aria-hidden` no longer updates correctly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants