Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] fix(Breadcrumb,Button,AnchorButton): improve onClick type #5945

Merged
merged 4 commits into from
Feb 14, 2023
Merged

[core] fix(Breadcrumb,Button,AnchorButton): improve onClick type #5945

merged 4 commits into from
Feb 14, 2023

Conversation

adidahiya
Copy link
Contributor

@adidahiya adidahiya commented Feb 14, 2023 •
edited
Loading

Building off #5944:

  • fix(Breadcrumb): add onFocus event handler support; improve specificity of onClick typedef
  • fix(Button, AnchorButton): do not attach onFocus handler if disabled

@adidahiya adidahiya changed the title add onFocus to Breadcrumb, Button, AnchorButton [core] fix(Breadcrumb, Button, AnchorButton): improve handler typedefs Feb 14, 2023
@adidahiya adidahiya changed the title [core] fix(Breadcrumb, Button, AnchorButton): improve handler typedefs [core] fix(Breadcrumb, Button, AnchorButton): improve onClick typedef Feb 14, 2023
@adidahiya
Copy link
Contributor Author

revert lint rule changes 🤦‍

Build artifact links for this commit: documentation | landing | table | demo

This is an automated comment from the deploy-preview CircleCI job.

@adidahiya adidahiya changed the title [core] fix(Breadcrumb, Button, AnchorButton): improve onClick typedef [core] fix(Breadcrumb,Button,AnchorButton): improve onClick type Feb 14, 2023
@adidahiya adidahiya merged commit 3dde016 into develop Feb 14, 2023
@adidahiya adidahiya deleted the ad/core-action-props branch February 14, 2023 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@adidahiya