Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] feat(Tab): support icons and tags inside tab titles #5950

Merged
merged 7 commits into from
Feb 27, 2023
Merged

[core] feat(Tab): support icons and tags inside tab titles #5950

merged 7 commits into from
Feb 27, 2023

Conversation

CPerinet
Copy link
Contributor

No description provided.

@CPerinet CPerinet mentioned this pull request Feb 20, 2023
Merged
@adidahiya
Copy link
Contributor

I updated the API to use two props tagContent and tagProps, I think this is a little cleaner (I don't like the { children: "4" } syntax as much):

2023-02-27 16 08 23

@adidahiya adidahiya marked this pull request as ready for review February 27, 2023 21:10
@adidahiya adidahiya changed the title Add support for Icon and Tag on Tabs [core] feat(Tab): add support for icons and tags inside tab titles Feb 27, 2023
adidahiya
adidahiya suggested changes Feb 27, 2023
View reviewed changes
Copy link
Contributor

@adidahiya adidahiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

self-review

packages/core/src/components/tabs/tabTitle.tsx Outdated Show resolved Hide resolved
packages/core/src/components/tabs/tab.tsx Show resolved Hide resolved
@adidahiya adidahiya changed the title [core] feat(Tab): add support for icons and tags inside tab titles [core] feat(Tab): support icons and tags inside tab titles Feb 27, 2023
@adidahiya adidahiya merged commit 0d53938 into palantir:develop Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adidahiya adidahiya adidahiya approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CPerinet @adidahiya