Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] feat(Icon): new prop 'svgProps' #5979

Merged
merged 3 commits into from
Feb 28, 2023

Conversation

bvandercar-vt
Copy link
Contributor

@bvandercar-vt bvandercar-vt commented Feb 28, 2023

Fixes #0000

Checklist

  • Includes tests
  • Update documentation

Changes proposed in this pull request:

allow passing of props to SVG element in the Icon.

Reviewers should focus on:

Example usage:

We are using an Icon as the target of a Tooltip2. So, we cannot use the title prop of the Icon, as this creates 2 visible tooltips when hovered (the title html tooltip, and the Tooltip2 content). However, we still need the SVG to have an accessible label, so we want to be able to pass the aria-label prop to it (as opposed to a title). With this, will also override to set aria-hidden=false (as was given by #5955)

@adidahiya adidahiya changed the title feat(Icon): SVGprops [core] feat(Icon): new prop 'svgProps' Feb 28, 2023
@adidahiya adidahiya merged commit 7cd1e13 into palantir:develop Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants