Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[node-build-scripts] fix(generate-css-variables): whitespace in maps #5991

Merged
merged 1 commit into from
Mar 2, 2023

Conversation

adidahiya
Copy link
Contributor

Checklist

  • Includes tests

Changes proposed in this pull request:

Fix another Less syntax error in core v4.17.3 variables.less:

@pt-dark-input-intent-box-shadow-colors: {
  primary: #4c90f0;
  success: #32a467;
  warning: #ec9a3c;
  "danger":#e76a6e, ;
};

should be instead (fixed):

@pt-dark-input-intent-box-shadow-colors: {
  primary: #4c90f0;
  success: #32a467;
  warning: #ec9a3c;
  danger: #e76a6e;
};

Reviewers should focus on:

Regression test

@@ -141,7 +141,7 @@ $pt-dark-input-intent-box-shadow-colors: (
"primary": $blue4,
"success": $green4,
"warning": $orange4,
"danger" : $red4,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was causing the regex to be tripped up... I've removed the extra whitespace, but also added code to handle it if necessary

@adidahiya
Copy link
Contributor Author

[node-build-scripts] fix(generate-css-variables): whitespace in maps

Build artifact links for this commit: documentation | landing | table | demo

This is an automated comment from the deploy-preview CircleCI job.

@adidahiya adidahiya merged commit cfde6bd into develop Mar 2, 2023
@adidahiya adidahiya deleted the ad/fix-less-map-variables branch March 2, 2023 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant