Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] fix(TagInput): make sure ResizableInput span is invisible #5997

Merged
merged 2 commits into from
Mar 6, 2023
Merged

[core] fix(TagInput): make sure ResizableInput span is invisible #5997

merged 2 commits into from
Mar 6, 2023

Conversation

JosephChotard
Copy link
Contributor

Checklist

  • [ N/A] Includes tests
  • [ N/A] Update documentation

Changes proposed in this pull request:

In some scenarios, other styles might clash making the supposedly hidden span not invisible...

Reviewers should focus on:

Screenshot

Example of it broken:
Screenshot 2023-03-06 at 17 53 53

@JosephChotard
Copy link
Contributor Author

@adidahiya I also just noticed that when there are no tags selected the input doesn't scale with the content (it only does it when at least one tag is selected). I've found some workarounds but they're quite ugly so will refine and submit another PR for it

@adidahiya
Copy link
Contributor

when there are no tags selected the input doesn't scale with the content

@JosephChotard by "content" here, do you mean the placeholder text?

@adidahiya adidahiya changed the title fix: make sure span is really invisible [core] fix(TagInput): make sure ResizableInput span is invisible Mar 6, 2023
@JosephChotard
Copy link
Contributor Author

JosephChotard commented Mar 6, 2023

when there are no tags selected the input doesn't scale with the content

@JosephChotard by "content" here, do you mean the placeholder text?

No the actual text typed by the user. The input only expands larger when at least one tag is present. Seems to be a styling bug and not a logic one.
Screenshot 2023-03-06 at 21 24 13
Screenshot 2023-03-06 at 21 23 59

@adidahiya adidahiya merged commit b34e002 into palantir:develop Mar 6, 2023
@JosephChotard JosephChotard deleted the jc/fix-resizeable-input branch March 7, 2023 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants