[v5] [core] fix(Icon): don't use default loader if icon is already loaded #6158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[v5] [core] fix(Icon): don't use default loader if icon is already loadedBuild artifact links for this commit: documentation | landing | table | demoThis is an automated comment from the deploy-preview CircleCI job. |
move error to , fix TagInput testsBuild artifact links for this commit: documentation | landing | table | demoThis is an automated comment from the deploy-preview CircleCI job. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6152
Checklist
Changes proposed in this pull request:
Update icon loading logic in
<Icon>to avoid loading icon components with the default loader (which will be invalid in non-webpack bundlers) in cases when the icon has already been loaded (throughIcons.loadAll()orIcons.load()).It's a bit difficult to test this change in the current build system. I'll test this out after the next
.alpharelease. I will consider adding a Vite build package to this monorepo to test this kind of thing out in the future (perhaps packages/demo-app is a good candidate).