-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[core] fix Toaster type backcompat, better OverlayToaster docs #6165
Conversation
[core] fix: backwards-compatibility of Toaster typeBuild artifact links for this commit: documentation | landing | table | demoThis is an automated comment from the deploy-preview CircleCI job. |
adjust typeBuild artifact links for this commit: documentation | landing | table | demoThis is an automated comment from the deploy-preview CircleCI job. |
Here's what |
6b5d423 was still problematic and had this compatibility issue:
the correct fix is to use the simplest type alias: |
adjust type again, add regresison testBuild artifact links for this commit: documentation | landing | table | demoThis is an automated comment from the deploy-preview CircleCI job. |
distinguish between ref callbacks and objectsBuild artifact links for this commit: documentation | landing | table | demoThis is an automated comment from the deploy-preview CircleCI job. |
fix code example, add one testBuild artifact links for this commit: documentation | landing | table | demoThis is an automated comment from the deploy-preview CircleCI job. |
Fixes a regression in the
Toaster
type. Previously, this was assignable to the type of the whole class component, which includes more methods than simplyToasterInstance
.See https://github.com/palantir/blueprint/pull/6146/files#r1195378467