[v5] [core] feat: restore Toaster.create() support #6175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[v5] [core] feat: restore Toaster.create() supportBuild artifact links for this commit: documentation | landing | table | demoThis is an automated comment from the deploy-preview CircleCI job. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
Restore support for
Toaster.create()as an alias forOverlayToaster.create().Keeping this alias around is not ideal, since we'd like people to move towards using
OverlayToasterand drop theToastertype + value completely, but that break would cause a lot of code changes in the v5.0 upgrade which feel unnecessary right now. We can continue to supportToaster.create()pretty easily and remove it in a future major version after we've provided a codemod for users to migrate toOverlayToaster.create().Reviewers should focus on:
No regressions
Screenshot
N/A