[core] feat(HTMLSelect): new prop iconName #6185
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
I've observed users customizing the HTMLSelect icon to use "caret-down" instead of the default "double-caret-vertical". We should make this a more first-class option instead of relying on
iconProps
. This is mainly motivated by the fact thaticonProps.icon
is being removed in Blueprint v5, so we need to provide a migration path in v4.x.Also added a new interactive example for HTMLSelect to the docs
Reviewers should focus on:
New example, no regressions
Screenshot