[table] fix regression in stricter type for context menu #6197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rename MenuContext to MenuContextImplBuild artifact links for this commit: documentation | landing | table | demoThis is an automated comment from the deploy-preview CircleCI job. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a regression in #6196, we can't require the more specific
MenuContexttype yet, we need to continue being compatible with the deprecatedIMenuContexttype in<CopyCellsMenuItem>and<TableBody>props.It turns out that
MenuContextwas not exported until #6196, so it's safe to rename the class toMenuContextImpl(which will be its name in v5.0) and useMenuContextto simply be an alias forIMenuContextnow. This will fix any assignability issues caused by the latest @blueprintjs/table release.