[popover2] fix(ContextMenu2): disable native menu correctly with content function API #6227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[popover2] fix(ContextMenu2): disable native menu correctly with content function APIBuild artifact links for this commit: documentation | landing | table | demoThis is an automated comment from the deploy-preview CircleCI job. |
Add more unit testsBuild artifact links for this commit: documentation | landing | table | demoThis is an automated comment from the deploy-preview CircleCI job. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6225
Checklist
Changes proposed in this pull request:
Fix implementation of ContextMenu2's "contextmenu" event handler to behave correctly when
contentis specified as a render prop.Previously, the event handler was referencing outdated state for the menu content and incorrectly assuming that the user returned an
undefinedmenu (a typical usage pattern in user code whencontentProps.mouseEvent === undefined).Now, we make sure to run the
props.content()render function again in the event handler to make sure we have the latest rendered menu content.Reviewers should focus on:
No regressions in ContextMenu2; completeness of unit tests.
Screenshot