Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v5] [popover2] fix(Popover2): restore basic support for some legacy class names #6228

Merged
merged 1 commit into from
Jun 20, 2023

Conversation

adidahiya
Copy link
Contributor

@adidahiya adidahiya commented Jun 20, 2023

Changes proposed in this pull request:

Fix a subtle bug in { Popover2 } from "@blueprintjs/popover2".

Previously, this export was a simple alias for { Popover } from "@blueprintjs/core". When upgrading code bases to Blueprint v5, I found a some custom styles which reference CSS selectors such as:

#{bp.$ns}-popover2-target { ... }
#{bp.$ns}-popover2 { ... }
#{bp.$ns}-popover2-content { ... }
#{bp.$ns}-popover2-open { ... }
#{bp.$ns}-popover2-arrow-fill { ... }

<Popover> no longer renders those class names, which constitutes a break in the CSS API. We expect some breaks, but it's also possible to mitigate them by restoring some of the popover2 classes in <Popover2>. We can't reasonably add back all of them, but we can cover the most used one: the target element class.

<Popover2 />
// will now render:
<Popover className="bp5-popover-target" popoverClassName="bp5-popover" />

@adidahiya
Copy link
Contributor Author

[v5] [popover2] fix(Popover2): restore basic support for some legacy class names

Build artifact links for this commit: documentation | landing | table | demo

This is an automated comment from the deploy-preview CircleCI job.

@adidahiya adidahiya merged commit ea5fa89 into next Jun 20, 2023
@adidahiya adidahiya deleted the ad/v5-popover2-class branch June 20, 2023 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant