[v5] [core] feat: remove @juggle/resize-observer in favor of native API #6234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkillian
commented
Jun 22, 2023
| @@ -72,7 +71,8 @@ export class ResizeSensor extends AbstractPureComponent<ResizeSensorProps> { | |||
|
|
|||
| private prevElement: HTMLElement | undefined = undefined; | |||
|
|
|||
| private observer = new ResizeObserver(entries => this.props.onResize?.(entries)); | |||
| private observer = | |||
| globalThis.ResizeObserver != null ? new ResizeObserver(entries => this.props.onResize?.(entries)) : undefined; | |||
There was a problem hiding this comment.
Unsure if this is the best way to make things work correctly in an isomorphic setting, but it seemed reasonable to me and got the tests to pass locally
|
Nice, this sounds like a good idea. Just in time for v5.0, I'm about to cut the stable release this week. I'm working on the |
|
Additional note: it sounds like the caveats listed here in "Switching between native and polyfilled versions" don't apply to us since we don't actually use any of the |
adidahiya
changed the title
adidahiya
approved these changes
Jun 22, 2023
|
Oops, sorry for targeting the wrong branch, thanks for taking care of that and merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6233
Checklist
Changes proposed in this pull request:
Removes the use of the
@juggle/resize-observerpolyfill in favor of directly using the native API.Reviewers should focus on:
Is the code to support isomoprhic rendering okay?
Screenshot
N/A