Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] fix(Callout): load intent icons statically #6254

Merged
merged 3 commits into from
Jul 6, 2023

Conversation

adidahiya
Copy link
Contributor

Fixes #6249 (comment)

Changes proposed in this pull request:

Refactor Callout to load icons statically from @blueprintjs/icons when they are specified using the intent prop. This reduces the dependency on dynamic icon loaders in core component implementations.

Reviewers should focus on:

No regressions in Callout docs example

@adidahiya
Copy link
Contributor Author

[core] fix(Callout): load intent icons statically

Build artifact links for this commit: documentation | landing | table | demo

This is an automated comment from the deploy-preview CircleCI job.

@adidahiya
Copy link
Contributor Author

fix tests

Build artifact links for this commit: documentation | landing | table | demo

This is an automated comment from the deploy-preview CircleCI job.

@adidahiya
Copy link
Contributor Author

Fix callout tests

Build artifact links for this commit: documentation | landing | table | demo

This is an automated comment from the deploy-preview CircleCI job.

@adidahiya adidahiya merged commit 8623da5 into develop Jul 6, 2023
@adidahiya adidahiya deleted the ad/fix-callout-icon-loading branch July 6, 2023 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Is it expected that the icon-related files are output when built even if icons are not imported dynamically?
1 participant