Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[node-build-scripts] chore: use non-deprecated syntax to import 'sass' #6261

Merged
merged 1 commit into from
Jul 5, 2023

Conversation

adidahiya
Copy link
Contributor

Changes proposed in this pull request:

Migrate import sass from "sass" imports to use the import * as sass syntax to avoid some deprecation warnings that are now being produced by the latest version of dart-sass.

Reviewers should focus on:

N/A - if it builds successfully, it's good to go :shipit:

@adidahiya
Copy link
Contributor Author

[node-build-scripts] chore: use non-deprecated syntax to import 'sass'

Build artifact links for this commit: documentation | landing | table | demo

This is an automated comment from the deploy-preview CircleCI job.

@adidahiya
Copy link
Contributor Author

Before (link to CI job):

$ sass-compile ./src
$ tsc -p ./src -m commonjs --outDir lib/cjs
`import sass from 'sass'` is deprecated.
Please use `import * as sass from 'sass'` instead.
[sass-compile] Finished compiling all input .scss files

After (link to CI job):

$ sass-compile ./src
$ tsc -p ./src -m commonjs --outDir lib/cjs
$ tsc -p ./src -t esnext --outDir lib/esnext
[sass-compile] Finished compiling all input .scss files.

@adidahiya adidahiya merged commit 9669182 into develop Jul 5, 2023
@adidahiya adidahiya deleted the ad/sass-import-syntax branch July 5, 2023 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant