Enable react-hooks ESLint rules & fix associated errors #6277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adidahiya
approved these changes
Jul 17, 2023
There was a problem hiding this comment.
nice, thanks @braeden!
I checked that the hotkeys example still works in the latest docs preview build
adidahiya
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes n/a
Checklist
Changes proposed in this pull request:
add the following eslint rules:
Reviewers should focus on:
The changes that I had to make to fix
rules-of-hooksoperating in an error capacity. (for context on why that's an especially critical one https://legacy.reactjs.org/docs/hooks-rules.html).Screenshot