Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[select] fix(Select, MultiSelect): load icons statically #6318

Merged
merged 1 commit into from
Aug 10, 2023

Conversation

tonooo71
Copy link
Contributor

@tonooo71 tonooo71 commented Aug 9, 2023

related to #6249

Checklist

  • Includes tests
  • Update documentation

Changes proposed in this pull request:

Select and MultiSelect components were dynamically loading icons, modified to load them statically.

Reviewers should focus on:

  • Whether the appropriate icons are being loaded.
  • Whether there are any other locations that are dynamically loading icons.

Best regards.

@palantirtech
Copy link
Member

Thanks for your interest in palantir/blueprint, @tonooo71! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request.

Copy link
Contributor

@adidahiya adidahiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good in docs preview 👍🏽

:shipit:

@adidahiya adidahiya changed the title [select] fix: load icons statically [select] fix(Select, MultiSelect): load icons statically Aug 9, 2023
Copy link
Contributor

@gluxon gluxon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great. Thanks!

@gluxon gluxon merged commit cba5612 into palantir:develop Aug 10, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants