Pass portalStopPropagationEvents prop given to Popover to underlying Overlay
#6319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pass portalStopPropagationEvents prop from Portal to underlying OverlayBuild artifact links for this commit: documentation | landing | table | demoThis is an automated comment from the deploy-preview CircleCI job. |
gluxon
changed the title
portalStopPropagationEvents prop from Portal to underlying Overlay
gluxon
changed the title
portalStopPropagationEvents prop from Portal to underlying OverlayportalStopPropagationEvents prop given to Popover to underlying Overlay
dylanrcooke
approved these changes
Aug 18, 2023
pgoldberg
approved these changes
Aug 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
In #6093, the
portalStopPropagationEventsprop was added to the<Overlay />component. Since thePopoverPropsextendsOverlayableProps, popovers now also accept this new prop. However, the<Popover />component wasn't using this new prop and simply discard it.Let's propagate it to the underlying
<Overlay />. I think this was the original intention in #6093.