palantir · adidahiya · Aug 29, 2023 · Aug 28, 2023 · Aug 29, 2023 · Aug 29, 2023
diff --git a/.github/dependabot.yml b/.github/dependabot.yml
@@ -16,6 +16,9 @@ updates:
           - "eslint"
           - "eslint-*"
           - "@typescript-eslint/*"
+        exclude-patterns:
+          # Breaking regression in v2.27.0 forces us to pin to v2.26.x, see https://github.com/import-js/eslint-plugin-import/issues/2685
+          - "eslint-plugin-import"
       postcss:
         patterns:
           - "postcss"

diff --git a/package.json b/package.json
@@ -48,9 +48,9 @@
         "chai": "^4.3.7",
         "cross-env": "^7.0.3",
         "dedent": "^0.7.0",
-        "eslint": "^8.36.0",
-        "eslint-config-prettier": "^8.7.0",
-        "eslint-plugin-prettier": "^4.2.1",
+        "eslint": "^8.48.0",
+        "eslint-config-prettier": "^9.0.0",
+        "eslint-plugin-prettier": "^5.0.0",
         "gh-pages": "^5.0.0",
         "http-server": "^14.1.1",
         "lerna": "^6.5.1",

diff --git a/packages/eslint-config/package.json b/packages/eslint-config/package.json
@@ -5,15 +5,15 @@
     "dependencies": {
         "@blueprintjs/eslint-plugin": "^3.0.1",
         "@blueprintjs/tslint-config": "^4.0.0",
-        "@typescript-eslint/eslint-plugin": "^5.59.8",
-        "@typescript-eslint/eslint-plugin-tslint": "^5.59.8",
-        "@typescript-eslint/parser": "^5.59.8",
-        "eslint": "^8.41.0",
-        "eslint-plugin-deprecation": "^1.4.1",
+        "@typescript-eslint/eslint-plugin": "^6.5.0",
+        "@typescript-eslint/eslint-plugin-tslint": "^6.5.0",
+        "@typescript-eslint/parser": "^6.5.0",
+        "eslint": "^8.48.0",
+        "eslint-plugin-deprecation": "^1.5.0",
         "eslint-plugin-header": "^3.1.1",
         "eslint-plugin-import": "~2.26.0",
-        "eslint-plugin-jsdoc": "^46.2.4",
-        "eslint-plugin-react": "^7.32.2",
+        "eslint-plugin-jsdoc": "^46.5.0",
+        "eslint-plugin-react": "^7.33.2",
         "eslint-plugin-react-hooks": "^4.6.0"
     },
     "repository": {

diff --git a/packages/eslint-plugin/.mocharc.json b/packages/eslint-plugin/.mocharc.json
diff --git a/packages/eslint-plugin/.swcrc b/packages/eslint-plugin/.swcrc
@@ -0,0 +1,11 @@
+{
+    "test": ".*.ts$",
+    "jsc": {
+      "parser": {
+        "syntax": "typescript"
+      }
+    },
+    "module": {
+      "type": "nodenext"
+    }
+  }
diff --git a/packages/eslint-plugin/package.json b/packages/eslint-plugin/package.json
@@ -9,18 +9,19 @@
         "lint": "run-p lint:es",
         "lint:es": "es-lint",
         "lint-fix": "es-lint --fix",
-        "test": "mocha"
+        "test": "SWC_NODE_PROJECT=./tsconfig.test.json mocha --require @swc-node/register --watch-extensions ts,tsx 'test/**/*.{ts,tsx}'"
     },
     "dependencies": {
-        "@typescript-eslint/utils": "^5.55.0",
-        "eslint": "^8.36.0"
+        "@typescript-eslint/utils": "^6.5.0",
+        "eslint": "^8.48.0"
     },
     "devDependencies": {
         "@blueprintjs/node-build-scripts": "^8.0.1",
+        "@swc/core": "^1.3.80",
+        "@swc-node/register": "^1.6.7",
         "@types/dedent": "~0.7.0",
         "dedent": "^0.7.0",
         "mocha": "^10.2.0",
-        "ts-node": "^10.9.1",
         "typescript": "~4.9.5"
     },
     "repository": {

diff --git a/packages/eslint-plugin/src/rules/classes-constants.ts b/packages/eslint-plugin/src/rules/classes-constants.ts
@@ -33,7 +33,7 @@ export const classesConstantsRule = createRule<[], MessageIds>({
     meta: {
         docs: {
             description: "Enforce usage of Classes constants over namespaced string literals.",
-            recommended: "error",
+            recommended: "recommended",
             requiresTypeChecking: false,
         },
         fixable: "code",

diff --git a/packages/eslint-plugin/src/rules/html-components.ts b/packages/eslint-plugin/src/rules/html-components.ts
@@ -31,7 +31,7 @@ export const htmlComponentsRule = createRule<[], MessageIds>({
     meta: {
         docs: {
             description: "Enforce usage of Blueprint components over JSX intrinsic elements.",
-            recommended: "error",
+            recommended: "recommended",
             requiresTypeChecking: false,
         },
         fixable: "code",

diff --git a/packages/eslint-plugin/src/rules/icon-components.ts b/packages/eslint-plugin/src/rules/icon-components.ts
@@ -30,7 +30,7 @@ export const iconComponentsRule = createRule<Options, MessageIds>({
     meta: {
         docs: {
             description: "Enforce usage of JSX Icon components over IconName string literals (or vice-versa)",
-            recommended: "error",
+            recommended: "recommended",
             requiresTypeChecking: false,
         },
         fixable: "code",
@@ -40,6 +40,7 @@ export const iconComponentsRule = createRule<Options, MessageIds>({
         },
         schema: [
             {
+                type: "string",
                 enum: [OPTION_COMPONENT, OPTION_LITERAL],
             },
         ],

diff --git a/packages/eslint-plugin/src/rules/index.ts b/packages/eslint-plugin/src/rules/index.ts
@@ -14,6 +14,10 @@
  * limitations under the License.
  */
 
+// HACKHACK: workaround to satisfy TS compiler, we need a direct type reference to be able to infer TSESLint.RuleModule
+// @ts-expect-error
+import type { TSESLint } from "@typescript-eslint/utils";
+
 import { classesConstantsRule } from "./classes-constants";
 import { htmlComponentsRule } from "./html-components";
 import { iconComponentsRule } from "./icon-components";

diff --git a/...ages/eslint-plugin/src/rules/no-deprecated-components/createNoDeprecatedComponentsRule.ts b/...ages/eslint-plugin/src/rules/no-deprecated-components/createNoDeprecatedComponentsRule.ts
@@ -38,7 +38,7 @@ export function createNoDeprecatedComponentsRule(
             docs: {
                 description: `Reports on usage of deprecated Blueprint components${descriptionFromClause} and recommends migrating to their corresponding non-deprecated API alternatives.`,
                 requiresTypeChecking: false,
-                recommended: "error",
+                recommended: "recommended",
             },
             messages: {
                 migration:
@@ -48,6 +48,7 @@ export function createNoDeprecatedComponentsRule(
             },
             schema: [
                 {
+                    type: "string",
                     enum: ["migration", "migrationWithPropUsage"],
                 },
             ],

diff --git a/packages/eslint-plugin/src/rules/no-deprecated-components/no-deprecated-components.ts b/packages/eslint-plugin/src/rules/no-deprecated-components/no-deprecated-components.ts
@@ -2,6 +2,7 @@
  * (c) Copyright 2022 Palantir Technologies Inc. All rights reserved.
  */
 
+import { TSESLint } from "@typescript-eslint/utils";
 import { createNoDeprecatedComponentsRule } from "./createNoDeprecatedComponentsRule";
 import { coreComponentsMigrationMapping } from "./no-deprecated-core-components";
 import { datetimeComponentsMigrationMapping } from "./no-deprecated-datetime-components";
@@ -14,7 +15,7 @@ import { tableComponentsMigrationMapping } from "./no-deprecated-table-component
  * Note that this does not rely on the \@deprecated JSDoc annotation, and is thus distinct/very different from the
  * deprecated/deprecated ESLint rule
  */
-export const noDeprecatedComponentsRule = createNoDeprecatedComponentsRule(
+export const noDeprecatedComponentsRule: TSESLint.RuleModule<string, unknown[]> = createNoDeprecatedComponentsRule(
     "no-deprecated-components",
     ["@blueprintjs/core", "@blueprintjs/datetime", "@blueprintjs/select", "@blueprintjs/table"],
     {

diff --git a/packages/eslint-plugin/src/rules/no-deprecated-components/no-deprecated-core-components.ts b/packages/eslint-plugin/src/rules/no-deprecated-components/no-deprecated-core-components.ts
@@ -2,6 +2,7 @@
  * (c) Copyright 2022 Palantir Technologies Inc. All rights reserved.
  */
 
+import { TSESLint } from "@typescript-eslint/utils";
 import { createNoDeprecatedComponentsRule } from "./createNoDeprecatedComponentsRule";
 
 export const coreComponentsMigrationMapping = {
@@ -14,7 +15,7 @@ export const coreComponentsMigrationMapping = {
  * of deprecated components from @blueprintjs/core. This is useful for incremental migration to
  * newer Blueprint APIs.
  */
-export const noDeprecatedCoreComponentsRule = createNoDeprecatedComponentsRule(
+export const noDeprecatedCoreComponentsRule: TSESLint.RuleModule<string, unknown[]> = createNoDeprecatedComponentsRule(
     "no-deprecated-core-components",
     ["@blueprintjs/core"],
     coreComponentsMigrationMapping,

diff --git a/...ges/eslint-plugin/src/rules/no-deprecated-components/no-deprecated-datetime-components.ts b/...ges/eslint-plugin/src/rules/no-deprecated-components/no-deprecated-datetime-components.ts
@@ -2,6 +2,7 @@
  * (c) Copyright 2022 Palantir Technologies Inc. All rights reserved.
  */
 
+import { TSESLint } from "@typescript-eslint/utils";
 import { createNoDeprecatedComponentsRule } from "./createNoDeprecatedComponentsRule";
 
 export const datetimeComponentsMigrationMapping = {
@@ -14,8 +15,9 @@ export const datetimeComponentsMigrationMapping = {
  * of deprecated components from @blueprintjs/datetime. This is useful for incremental migration to
  * newer Blueprint APIs.
  */
-export const noDeprecatedDatetimeComponentsRule = createNoDeprecatedComponentsRule(
-    "no-deprecated-datetime-components",
-    ["@blueprintjs/datetime"],
-    datetimeComponentsMigrationMapping,
-);
+export const noDeprecatedDatetimeComponentsRule: TSESLint.RuleModule<string, unknown[]> =
+    createNoDeprecatedComponentsRule(
+        "no-deprecated-datetime-components",
+        ["@blueprintjs/datetime"],
+        datetimeComponentsMigrationMapping,
+    );
diff --git a/packages/eslint-plugin/src/rules/no-deprecated-components/no-deprecated-select-components.ts b/packages/eslint-plugin/src/rules/no-deprecated-components/no-deprecated-select-components.ts
@@ -2,6 +2,7 @@
  * (c) Copyright 2022 Palantir Technologies Inc. All rights reserved.
  */
 
+import { TSESLint } from "@typescript-eslint/utils";
 import { createNoDeprecatedComponentsRule } from "./createNoDeprecatedComponentsRule";
 
 export const selectComponentsMigrationMapping = {
@@ -13,8 +14,9 @@ export const selectComponentsMigrationMapping = {
  * of deprecated components from @blueprintjs/select. This is useful for incremental migration to
  * newer Blueprint APIs.
  */
-export const noDeprecatedSelectComponentsRule = createNoDeprecatedComponentsRule(
-    "no-deprecated-select-components",
-    ["@blueprintjs/select"],
-    selectComponentsMigrationMapping,
-);
+export const noDeprecatedSelectComponentsRule: TSESLint.RuleModule<string, unknown[]> =
+    createNoDeprecatedComponentsRule(
+        "no-deprecated-select-components",
+        ["@blueprintjs/select"],
+        selectComponentsMigrationMapping,
+    );
diff --git a/packages/eslint-plugin/src/rules/no-deprecated-components/no-deprecated-table-components.ts b/packages/eslint-plugin/src/rules/no-deprecated-components/no-deprecated-table-components.ts
@@ -2,6 +2,7 @@
  * (c) Copyright 2022 Palantir Technologies Inc. All rights reserved.
  */
 
+import { TSESLint } from "@typescript-eslint/utils";
 import { createNoDeprecatedComponentsRule } from "./createNoDeprecatedComponentsRule";
 
 export const tableComponentsMigrationMapping = {
@@ -15,7 +16,7 @@ export const tableComponentsMigrationMapping = {
  * of deprecated components from @blueprintjs/table. This is useful for incremental migration to
  * newer Blueprint APIs.
  */
-export const noDeprecatedTableComponentsRule = createNoDeprecatedComponentsRule(
+export const noDeprecatedTableComponentsRule: TSESLint.RuleModule<string, unknown[]> = createNoDeprecatedComponentsRule(
     "no-deprecated-table-components",
     ["@blueprintjs/table"],
     tableComponentsMigrationMapping,

diff --git a/packages/eslint-plugin/src/rules/no-deprecated-type-references.ts b/packages/eslint-plugin/src/rules/no-deprecated-type-references.ts
@@ -4,7 +4,7 @@
 
 // tslint:disable object-literal-sort-keys
 
-import { TSESTree } from "@typescript-eslint/utils";
+import { TSESLint, TSESTree } from "@typescript-eslint/utils";
 
 import { createRule } from "./utils/createRule";
 import { FixList } from "./utils/fixList";
@@ -193,20 +193,21 @@ export const noDeprecatedTypeReferencesRule = createRule<[], MessageIds>({
             description:
                 "Reports on usage of deprecated Blueprint types and recommends migrating to their corresponding replacements.",
             requiresTypeChecking: false,
-            recommended: "error",
+            recommended: "recommended",
         },
         fixable: "code",
         messages: {
             migration: "Usage of {{ deprecatedTypeName }} is deprecated, migrate to {{ newTypeName }} instead",
         },
         schema: [
             {
+                type: "string",
                 enum: ["migration"],
             },
         ],
     },
     defaultOptions: [],
-    create: context => {
+    create: (context: TSESLint.RuleContext<MessageIds, []>) => {
         const [deprecatedToNewType, newTypeToPackageName] = getTypeMappings();
         const deprecatedImports: Array<
             { namespace: string; type: "namespace" } | { type: "symbol"; symbolName: string; localSymbolName: string }

diff --git a/packages/eslint-plugin/src/rules/utils/createRule.ts b/packages/eslint-plugin/src/rules/utils/createRule.ts
@@ -14,9 +14,14 @@
  * limitations under the License.
  */
 
-import { ESLintUtils } from "@typescript-eslint/utils";
+import { ESLintUtils, TSESLint } from "@typescript-eslint/utils";
+import { RuleWithMetaAndName } from "@typescript-eslint/utils/eslint-utils";
+
+export type RuleCreator = <TOptions extends readonly unknown[], TMessageIds extends string>(
+    metadata: Readonly<RuleWithMetaAndName<TOptions, TMessageIds>>,
+) => TSESLint.RuleModule<TMessageIds, TOptions>;
 
 /** Create a rule and automatically fill its url based on the rule name. */
-export const createRule = ESLintUtils.RuleCreator(
+export const createRule: RuleCreator = ESLintUtils.RuleCreator(
     name => `https://github.com/palantir/blueprint/tree/develop/packages/eslint-plugin/src/rules/${name}.ts`,
 );
diff --git a/packages/eslint-plugin/src/rules/utils/getProgram.ts b/packages/eslint-plugin/src/rules/utils/getProgram.ts
@@ -20,13 +20,13 @@ import { AST_NODE_TYPES, TSESTree } from "@typescript-eslint/utils";
  * Return the top level node that is the greatest parent of the current node, if it is a Program.
  * Non-program top level parents return undefined.
  */
-export function getProgram(node: TSESTree.BaseNode & { type: AST_NODE_TYPES }): TSESTree.Program | undefined {
-    let curr = node;
+export function getProgram(node: TSESTree.BaseNode & TSESTree.NodeOrTokenData): TSESTree.Program | undefined {
+    let curr: TSESTree.BaseNode | TSESTree.Program = node;
     while (curr.parent != null) {
         curr = curr.parent;
     }
     if (curr.type === AST_NODE_TYPES.Program) {
-        return curr as TSESTree.Program;
+        return curr as unknown as TSESTree.Program;
     }
     return undefined;
 }
diff --git a/packages/eslint-plugin/src/tsconfig.json b/packages/eslint-plugin/src/tsconfig.json
@@ -3,6 +3,7 @@
     "compilerOptions": {
         "lib": ["es6", "dom"],
         "module": "commonjs",
+        "moduleResolution": "node16",
         "outDir": "../lib",
         "target": "ES2015"
     }

diff --git a/packages/eslint-plugin/test/tsconfig.json b/packages/eslint-plugin/test/tsconfig.json
@@ -1,13 +1,19 @@
 {
-    "extends": "ts-node/node16/tsconfig.json",
     "compilerOptions": {
+        "esModuleInterop": true,
+        "forceConsistentCasingInFileNames": true,
+        "moduleResolution": "nodenext",
+        "lib": ["es2021"],
+        "module": "commonjs",
         "noEmit": true,
         "noFallthroughCasesInSwitch": true,
         "noImplicitAny": true,
         "noImplicitReturns": true,
         "noUnusedLocals": true,
         "noUnusedParameters": true,
         "pretty": true,
-        "strict": true
-    }
+        "skipLibCheck": true,
+        "strict": true,
+        "target": "es2021"
+    },
 }
diff --git a/packages/node-build-scripts/package.json b/packages/node-build-scripts/package.json
@@ -23,7 +23,7 @@
         "cross-spawn": "^7.0.3",
         "css-select": "^5.1.0",
         "dom-serializer": "^2.0.0",
-        "eslint": "^8.43.0",
+        "eslint": "^8.48.0",
         "eslint-formatter-codeframe": "^7.32.1",
         "fs-extra": "^11.1.1",
         "glob": "^10.3.3",