-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[core] fix(NumericInput): increment/decrement with very small step size #6382
Merged
adidahiya
merged 6 commits into
palantir:develop
from
Rafael-Martins:numericinput/fix-stepsize
Sep 22, 2023
Merged
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
15e2526
feat: raise locale digits to ten
Rafael-Martins 96c0f01
fix: tune value
Rafael-Martins f448a57
test: cover numericInput digits issue
Rafael-Martins e4eeb23
fix: address pr comments
Rafael-Martins e80ba19
fix: remove console.log
Rafael-Martins 9d4d5b3
fix: added comment about roudingPriority type absence
Rafael-Martins File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,48 @@ | ||
/* | ||
* Copyright 2017 Palantir Technologies, Inc. All rights reserved. | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
import { assert } from "chai"; | ||
import { mount } from "enzyme"; | ||
import { spy } from "sinon"; | ||
import * as React from "react"; | ||
|
||
import { NumericInput } from "../../src"; | ||
|
||
describe("<NumericInput>", () => { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. there are already tests for this component in |
||
it("Initial state should be empty string", () => { | ||
const wrapper = mount(<NumericInput />); | ||
const input = wrapper.find("input"); | ||
|
||
assert.strictEqual(input.prop("value"), ""); | ||
}); | ||
|
||
it("Should handle increment up to 21 decimal digits", () => { | ||
const changeSpy = spy(); | ||
const wrapper = mount( | ||
<NumericInput | ||
onValueChange={changeSpy} | ||
value={0} | ||
stepSize={0.000000000000000001} | ||
minorStepSize={0.000000000000000001} | ||
/>, | ||
); | ||
const input = wrapper.find("input"); | ||
|
||
console.log(input.simulate("keydown", { key: "ArrowUp" })); | ||
|
||
assert.isTrue(changeSpy.calledWith(0.000000000000000001)); | ||
}); | ||
}); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why
21
? according to the NumberFormat docs, this should already be the default. maybe you need to adjust a different option likeroundingMode
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was misunderstanding how it works, I opened a task to enhance the docs in this part https://github.com/mdn/mdn/issues/444 😄