Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] fix(NumericInput): increment/decrement with very small step size #6382

Merged
merged 6 commits into from
Sep 22, 2023
Merged
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/core/src/components/forms/numericInputUtils.ts
Original file line number Diff line number Diff line change
@@ -30,7 +30,7 @@ function getDecimalSeparator(locale: string) {
}

export function toLocaleString(num: number, locale: string = "en-US") {
return sanitizeNumericInput(num.toLocaleString(locale), locale);
return sanitizeNumericInput(num.toLocaleString(locale, { maximumSignificantDigits: 21 }), locale);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why 21? according to the NumberFormat docs, this should already be the default. maybe you need to adjust a different option like roundingMode?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was misunderstanding how it works, I opened a task to enhance the docs in this part https://github.com/mdn/mdn/issues/444 😄

}

export function clampValue(value: number, min?: number, max?: number) {
48 changes: 48 additions & 0 deletions packages/core/test/forms/numericInputTests.tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,48 @@
/*
* Copyright 2017 Palantir Technologies, Inc. All rights reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/

import { assert } from "chai";
import { mount } from "enzyme";
import { spy } from "sinon";
import * as React from "react";

import { NumericInput } from "../../src";

describe("<NumericInput>", () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there are already tests for this component in packages/core/test/controls/numericInputTests.tsx. can you please move your new tests into that test suite?

it("Initial state should be empty string", () => {
const wrapper = mount(<NumericInput />);
const input = wrapper.find("input");

assert.strictEqual(input.prop("value"), "");
});

it("Should handle increment up to 21 decimal digits", () => {
const changeSpy = spy();
const wrapper = mount(
<NumericInput
onValueChange={changeSpy}
value={0}
stepSize={0.000000000000000001}
minorStepSize={0.000000000000000001}
/>,
);
const input = wrapper.find("input");

console.log(input.simulate("keydown", { key: "ArrowUp" }));

assert.isTrue(changeSpy.calledWith(0.000000000000000001));
});
});
1 change: 1 addition & 0 deletions packages/core/test/index.ts
Original file line number Diff line number Diff line change
@@ -42,6 +42,7 @@ import "./forms/asyncControllableInputTests";
import "./forms/fileInputTests";
import "./forms/formGroupTests";
import "./forms/textAreaTests";
import "./forms/numericInputTests";
import "./hotkeys/hotkeyTests";
import "./hotkeys/hotkeysParserTests";
import "./hotkeys/keyComboTagTests";