Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: migrate to @twbs/fantasticon #6538

Merged
merged 1 commit into from
Nov 13, 2023
Merged

chore: migrate to @twbs/fantasticon #6538

merged 1 commit into from
Nov 13, 2023

Conversation

adidahiya
Copy link
Contributor

@adidahiya adidahiya commented Nov 13, 2023

Changes proposed in this pull request:

Migrate from fantasticon v1.x to @twbs/fantasticon v2.x

Previously, we were stuck on fantasticon v1.x due to this bug. The Bootstrap team also avoided v2.x for the same reason. It appears that they have forked the project and have been steadily pushing updates in the @twbs/fantasticon package. It seems like a good option to keep our icon-related tooling up-to-date, since fantasticon v1.x is not receiving any updates.

Reviewers should focus on:

No regressions in icon rendering like #5074

Screenshot

image

image

@adidahiya
Copy link
Contributor Author

chore: migrate to @twbs/fantasticon

Build artifact links for this commit: documentation | landing | table | demo

This is an automated comment from the deploy-preview CircleCI job.

@adidahiya adidahiya merged commit a6ec7b3 into develop Nov 13, 2023
12 checks passed
@adidahiya adidahiya deleted the ad/fantasticon-fork branch November 13, 2023 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant