Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] feat(Button, AnchorButton): ellipsizeText prop #6543

Merged
merged 2 commits into from
Nov 13, 2023

Conversation

adidahiya
Copy link
Contributor

Fixes #6515

Checklist

  • Includes tests
  • Update documentation

Changes proposed in this pull request:

  • Use <Text> to render button text
  • feat(Button, AnchorButton): add new ellipsizeText prop which truncates long text that does not fit into a single line
    • This feature utilizes the <Text> component to detect overflow and render a native HTML tooltip to display the full overflowing text upon hover interaction

Reviewers should focus on:

  • Usage of <Text> in such a widely used component (although we already use it in <MenuItem>)
  • Functionality of the new feature
  • Updated docs example options

Screenshot

image

2023-11-13 17 20 39

@adidahiya
Copy link
Contributor Author

prettier

Build artifact links for this commit: documentation | landing | table | demo

This is an automated comment from the deploy-preview CircleCI job.

@adidahiya adidahiya merged commit 1a75dc9 into develop Nov 13, 2023
12 checks passed
@adidahiya adidahiya deleted the ad/button-ellipsize-text branch November 13, 2023 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Buttons should make it easy to style overflow text with ellipses
1 participant