Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(icon): allow aria-hidden override #6567

Conversation

bvandercar-vt
Copy link
Contributor

@bvandercar-vt bvandercar-vt commented Nov 26, 2023

Allow aria-hidden to be overriden in order to correctly follow the existing title jsdoc:

   /**
     * If this value is nullish, `false`, or an empty string, the component will assume
     * that the icon is decorative and `aria-hidden="true"` will be applied (can be overridden
     * by manually passing `aria-hidden` prop).
     */
    title?: string | false | null;

@adidahiya adidahiya merged commit 8b20af0 into palantir:develop Nov 27, 2023
12 checks passed
@bvandercar-vt bvandercar-vt deleted the bvandercar/icon/allow-aria-hidden-override branch November 7, 2024 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants