Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EntityTitle component #6590

Merged
merged 16 commits into from
Jan 8, 2024
Merged

Add EntityTitle component #6590

merged 16 commits into from
Jan 8, 2024

Conversation

mud
Copy link
Contributor

@mud mud commented Dec 7, 2023

Checklist

  • Includes tests
  • Update documentation

Changes proposed in this pull request:

Add a new EntityTitle component which generalizes a popular UI pattern.

Reviewers should focus on:

This PR addresses the review left on #6278

Screenshot

Screenshot 2023-12-07 at 5 31 47 PM

@adidahiya
Copy link
Contributor

clean up

Build artifact links for this commit: documentation | landing | table | demo

This is an automated comment from the deploy-preview CircleCI job.

@mud mud marked this pull request as ready for review December 8, 2023 01:20
@adidahiya
Copy link
Contributor

remove heading size

Build artifact links for this commit: documentation | landing | table | demo

This is an automated comment from the deploy-preview CircleCI job.

@adidahiya
Copy link
Contributor

add tests

Build artifact links for this commit: documentation | landing | table | demo

This is an automated comment from the deploy-preview CircleCI job.

@adidahiya
Copy link
Contributor

update demo example

Build artifact links for this commit: documentation | landing | table | demo

This is an automated comment from the deploy-preview CircleCI job.

@adidahiya adidahiya mentioned this pull request Jan 3, 2024
Copy link
Contributor

@adidahiya adidahiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great overall! thanks for pushing through this feature @mud

my one bit of feedback about the interactive example is that it looks a bit too much like a checkbox, and visitors might feel prompted to click it as a to-do list item

image

an alternative icon suggestion here might be "add-to-artifact":

image

packages/core/src/components/entity-title/entityTitle.tsx Outdated Show resolved Hide resolved
packages/core/test/entity-title/entityTitleTests.tsx Outdated Show resolved Hide resolved
packages/demo-app/src/examples/EntityTitleExample.tsx Outdated Show resolved Hide resolved
adidahiya added a commit that referenced this pull request Jan 8, 2024
@adidahiya
Copy link
Contributor

opened a PR to address my CR comments: #6633

@mud
Copy link
Contributor Author

mud commented Jan 8, 2024

thanks for addressing @adidahiya!

@adidahiya
Copy link
Contributor

[to/entity-title] address CR (#6633)

Build artifact links for this commit: documentation | landing | table | demo

This is an automated comment from the deploy-preview CircleCI job.

@adidahiya adidahiya merged commit aaf1fa9 into develop Jan 8, 2024
12 checks passed
@adidahiya adidahiya deleted the to/entity-title branch January 8, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants