[core] feat(Tabs): allow panel prop to be a renderer #6621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bvandercar-vt
changed the title
adidahiya
reviewed
Jan 4, 2024
| id="first" | ||
| panel={({ tabTitleId, tabPanelId }) => { | ||
| assert.equal(tabTitleId, generateTabTitleId(ID, "first")); | ||
| assert.equal(tabPanelId, generateTabPanelId(ID, "first")); |
There was a problem hiding this comment.
are you sure these assertions are getting run in this test? I think you need to use the Mocha async done syntax.
There was a problem hiding this comment.
Yeah I was a little confused on how to write this test, was curious how you would do it.
are you sure these assertions are getting run in this test?
Yep, it does work. If I change the expected value, I see a failure.
adidahiya
approved these changes
Feb 9, 2024
adidahiya
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(Tabs): allow
panelprop to be a renderer, pass tabTitleId and tabPanelId to the renderer.Reason: a developer may want to use these IDs for accessibility, such as
aria-controls.Checklist