Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[icons]: team, trophy, soccer ball, sports stadium #6627

Merged
merged 4 commits into from
Jan 5, 2024

Conversation

jessperrin
Copy link
Contributor

Fixes #0000

Checklist

  • Includes tests
  • Update documentation

Changes proposed in this pull request:

Soccer-based icons for an sports pilot.

image

@adidahiya
Copy link
Contributor

Clean up PR a bit

Build artifact links for this commit: documentation | landing | table | demo

This is an automated comment from the deploy-preview CircleCI job.

Copy link
Contributor

@adidahiya adidahiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

most of the icons look fine but 2 of them have extra markup that causes them to render incorrectly:

image image

@@ -0,0 +1,12 @@
<svg width="16" height="16" viewBox="0 0 16 16" fill="none" xmlns="http://www.w3.org/2000/svg">
<g clip-path="url(#clip0_1_17)">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the <g> wrapper and <defs> are superfluous, they should probably be removed from this file

@@ -0,0 +1,5 @@
<svg width="20" height="20" viewBox="0 0 20 20" fill="none" xmlns="http://www.w3.org/2000/svg">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this version of the sports-stadium icon markup looks better 👍

@@ -0,0 +1,10 @@
<svg width="20" height="20" viewBox="0 0 20 20" fill="none" xmlns="http://www.w3.org/2000/svg">
<g clip-path="url(#clip0_1_13)">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here, we should remove the <g> wrapper and the <defs> block

@jessperrin
Copy link
Contributor Author

Oh hm, would you mind making those changes? Not sure why those are there - is it due to something in the icon SVG?

@adidahiya
Copy link
Contributor

@jessperrin I'm not sure either, probably something to do with Figma export. Sure, I can make those fixes

@adidahiya
Copy link
Contributor

remove extraneous SVG markup

Build artifact links for this commit: documentation | landing | table | demo

This is an automated comment from the deploy-preview CircleCI job.

@adidahiya adidahiya merged commit c79d670 into develop Jan 5, 2024
12 checks passed
@adidahiya adidahiya deleted the jp/new-soccer-icons branch January 5, 2024 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants