Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] fix(KeyComboTag): use static icon imports #6629

Merged
merged 1 commit into from
Jan 8, 2024
Merged

[core] fix(KeyComboTag): use static icon imports #6629

merged 1 commit into from
Jan 8, 2024

Commits on Jan 6, 2024

  1. Use static icon imports for KeyComboTag icon 

    This component previously passed icon string names to a child Icon
component, preventing tree shaking of unused icons. Passing statically
imported icons from @blueprintjs/icons fixes this problem.

Related to #6249.
    @michael-yx-wu
    michael-yx-wu committed Jan 6, 2024
    Configuration menu
    Copy the full SHA
    c8d8ca6 View commit details
    Browse the repository at this point in the history