Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[icons] feat: crop, endnote, bring-forward, send-backward icons #6635

Merged
merged 4 commits into from
Jan 9, 2024
Merged

[icons] feat: crop, endnote, bring-forward, send-backward icons #6635

merged 4 commits into from
Jan 9, 2024

Conversation

davidburns573
Copy link
Contributor

Fixes #0000

Checklist

  • Includes tests
  • Update documentation

Changes proposed in this pull request:

Adds the crop, endnote, bring forward, and send backward icons. (Already approved by the blueprint design team)

Reviewers should focus on:

Making sure everything renders okay and the right files were changed.

Screenshot

Visible in files changed

@adidahiya
Copy link
Contributor

fix format

Build artifact links for this commit: documentation | landing | table | demo

This is an automated comment from the deploy-preview CircleCI job.

@adidahiya
Copy link
Contributor

fix

Build artifact links for this commit: documentation | landing | table | demo

This is an automated comment from the deploy-preview CircleCI job.

adidahiya
adidahiya suggested changes Jan 9, 2024
View reviewed changes
Copy link
Contributor

@adidahiya adidahiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some icons aren't rendering correctly due to extraneous markup:

image

resources/icons/20px/crop.svg Outdated Show resolved Hide resolved
resources/icons/20px/endnote.svg Outdated Show resolved Hide resolved
resources/icons/20px/send-backward.svg Outdated Show resolved Hide resolved
packages/icons/icons.json Outdated Show resolved Hide resolved
packages/icons/icons.json Outdated Show resolved Hide resolved
packages/icons/icons.json Outdated Show resolved Hide resolved
packages/icons/icons.json Outdated Show resolved Hide resolved
@adidahiya adidahiya changed the title Add crop, endnote, bring forward, and send backward icons [icons] feat: crop, endnote, bring-forward, send-backward icons Jan 9, 2024
@adidahiya
Copy link
Contributor

CR

Build artifact links for this commit: documentation | landing | table | demo

This is an automated comment from the deploy-preview CircleCI job.

adidahiya
adidahiya approved these changes Jan 9, 2024
View reviewed changes
Copy link
Contributor

@adidahiya adidahiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM in docs preview

image
image
image
image

--

although it is strange to me that the "send-backward" and "bring-forward" action names are asymmetrical, that does seem to be the industry standard in visual editor UIs:

image

image

@adidahiya adidahiya merged commit bb28b76 into develop Jan 9, 2024
12 checks passed
@adidahiya adidahiya deleted the db/new_icons branch January 9, 2024 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adidahiya adidahiya adidahiya approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davidburns573 @adidahiya