Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade to Node v20.11, use new module features #6661

Merged
merged 5 commits into from
Jan 19, 2024

Conversation

adidahiya
Copy link
Contributor

@adidahiya adidahiya commented Jan 19, 2024

Changes proposed in this pull request:

  • Upgrade to Node v20.11
  • Use new module system features
    • import.meta.dirname obviates the need for path.dirname(url.fileURLToPath(import.meta.url))
    • Import attributes are the new "Import assertions"
    • createRequire(import.meta.url).resolve(...) is now fileURLToPath(import.meta.resolve(...)
      • this is no less succinct, but possibly more idiomatic? reasonable devs may agree to disagree... 🤷🏽

@blueprintjs/node-build-scripts

  • ⚠️ break: update Node.js engine requirement to >=20.11

@blueprintjs/webpack-build-scripts

  • ⚠️ break: update Node.js engine requirement to >=20.11

Reviewers should focus on:

No tooling regressions

Screenshot

N/A

@adidahiya adidahiya marked this pull request as ready for review January 19, 2024 14:44
@adidahiya
Copy link
Contributor Author

adjust optional dependency

Build artifact links for this commit: documentation | landing | table | demo

This is an automated comment from the deploy-preview CircleCI job.

@adidahiya adidahiya merged commit dfd8e37 into develop Jan 19, 2024
11 of 12 checks passed
@adidahiya adidahiya deleted the ad/node-20.11 branch January 19, 2024 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant